Fix: MCL_Version print correct Version#293
Open
solara404 wants to merge 3 commits into
Open
Conversation
aaumar25
reviewed
Jun 25, 2026
| const imports: []const std.Build.Module.Import = &.{ | ||
| .{ .name = "build.zig.zon", .module = build_zig_zon }, | ||
| .{ .name = "chrono", .module = chrono.module("chrono") }, | ||
| .{ .name = "mmc_api", .module = mmc_api.module("mmc-api") }, |
Member
There was a problem hiding this comment.
This is wrong. Read the lines below that it is added.
main mod requires working mdfunc mod, test mod requires mdfunc_mock mod
aaumar25
requested changes
Jun 25, 2026
| std.log.info("CC-Link Version: {d}.{d}.{d}\n", .{ | ||
| mmc_api.cclink.version.major, | ||
| mmc_api.cclink.version.minor, | ||
| mmc_api.cclink.version.patch, |
Member
There was a problem hiding this comment.
This is also wrong. This is John's CCLink. The CTO firmware is inside mmc_api.mcl, but I do not think there is a version there. You can asks to CTO what version is the current firmware so we can match his version
Member
|
Also, can you add on the CI file to execute the test when targetting to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: #288
Depends on: #284